Remove the now unused jquery dependency#2682
Merged
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom Oct 6, 2022
Merged
Remove the now unused jquery dependency#2682PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
PrestonN merged 1 commit intoFreeTubeApp:developmentfrom
Conversation
absidue
requested review from
ChunkyProgrammer,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
github-actions
bot
added
PR: dependencies
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 6, 2022
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
bye jay kwery
PikachuEXE
approved these changes
Oct 6, 2022
ChunkyProgrammer
approved these changes
Oct 6, 2022
github-actions
bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the now unused jquery dependency
Pull Request Type
Related issue
closes #2360
Description
This is the last pull request in the jquery removal series.
Highlights:
Testing
As all references to jquery are gone, webpack doesn't bundle it in anymore, so this PR doesn't break anything.
Desktop